- 434
- 41
- 110
Доброго времени суток, копался я в ванильном коде 1.12.2 и нашел вот такое фигню, как бы это по-мягче сказать ...
Это что получается .. 128 мб уходит на расчет, какие блоки листвы должны опадать, а какие нет? До кучи поле не статик, и у класса не 1 наследник ...
Если кто знает патчи/ядра/моды/что-то еще, где это пофикшено - дайте ссылку на исходники ресурса (может я плохо гуглил и не нашел)
Очень не хочется самому исправлять это, математика с индексами выглядит сложной и страшной, искренне надеюсь, что за 10 лет кто-то да исправил это
Java:
public abstract class BlockLeaves extends Block implements net.minecraftforge.common.IShearable {
... 2-3 строки
int[] surroundings;
... 20-30 строк
public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand) {
... 5-7 строк
if (this.surroundings == null) {
this.surroundings = new int[32768];
}
... 60-70 строк
}
... 100-120 строк
}
Если кто знает патчи/ядра/моды/что-то еще, где это пофикшено - дайте ссылку на исходники ресурса (может я плохо гуглил и не нашел)
Очень не хочется самому исправлять это, математика с индексами выглядит сложной и страшной, искренне надеюсь, что за 10 лет кто-то да исправил это
BlockLeaves:
public abstract class BlockLeaves extends Block implements net.minecraftforge.common.IShearable {
public static final PropertyBool DECAYABLE = PropertyBool.create("decayable");
public static final PropertyBool CHECK_DECAY = PropertyBool.create("check_decay");
protected boolean leavesFancy;
int[] surroundings;
public BlockLeaves() {
super(Material.LEAVES);
this.setTickRandomly(true);
this.setCreativeTab(CreativeTabs.DECORATIONS);
this.setHardness(0.2F);
this.setLightOpacity(1);
this.setSoundType(SoundType.PLANT);
}
@Override
public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
int k = pos.getX();
int l = pos.getY();
int i1 = pos.getZ();
if (worldIn.isAreaLoaded(new BlockPos(k - 2, l - 2, i1 - 2), new BlockPos(k + 2, l + 2, i1 + 2))) {
for (int j1 = -1; j1 <= 1; ++j1) {
for (int k1 = -1; k1 <= 1; ++k1) {
for (int l1 = -1; l1 <= 1; ++l1) {
BlockPos blockpos = pos.add(j1, k1, l1);
IBlockState iblockstate = worldIn.getBlockState(blockpos);
if (iblockstate.getBlock().isLeaves(iblockstate, worldIn, blockpos)) {
iblockstate.getBlock().beginLeavesDecay(iblockstate, worldIn, blockpos);
}
}
}
}
}
}
public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand) {
if (!worldIn.isRemote) {
if (state.getValue(CHECK_DECAY) && state.getValue(DECAYABLE)) {
int k = pos.getX();
int l = pos.getY();
int i1 = pos.getZ();
if (this.surroundings == null) {
this.surroundings = new int[32768];
}
// Forge: prevent decaying leaves from updating neighbors and loading unloaded chunks
if (!worldIn.isAreaLoaded(pos, 1)) return;
// Forge: extend range from 5 to 6 to account for neighbor checks in world.markAndNotifyBlock -> world.updateObservingBlocksAt
if (worldIn.isAreaLoaded(pos, 6)) {
BlockPos.MutableBlockPos blockpos$mutableblockpos = new BlockPos.MutableBlockPos();
for (int i2 = -4; i2 <= 4; ++i2) {
for (int j2 = -4; j2 <= 4; ++j2) {
for (int k2 = -4; k2 <= 4; ++k2) {
IBlockState iblockstate = worldIn.getBlockState(blockpos$mutableblockpos.setPos(k + i2, l + j2, i1 + k2));
Block block = iblockstate.getBlock();
if (!block.canSustainLeaves(iblockstate, worldIn, blockpos$mutableblockpos.setPos(k + i2, l + j2, i1 + k2))) {
if (block.isLeaves(iblockstate, worldIn, blockpos$mutableblockpos.setPos(k + i2, l + j2, i1 + k2))) {
this.surroundings[(i2 + 16) * 1024 + (j2 + 16) * 32 + k2 + 16] = -2;
} else {
this.surroundings[(i2 + 16) * 1024 + (j2 + 16) * 32 + k2 + 16] = -1;
}
} else {
this.surroundings[(i2 + 16) * 1024 + (j2 + 16) * 32 + k2 + 16] = 0;
}
}
}
}
for (int i3 = 1; i3 <= 4; ++i3) {
for (int j3 = -4; j3 <= 4; ++j3) {
for (int k3 = -4; k3 <= 4; ++k3) {
for (int l3 = -4; l3 <= 4; ++l3) {
if (this.surroundings[(j3 + 16) * 1024 + (k3 + 16) * 32 + l3 + 16] == i3 - 1) {
if (this.surroundings[(j3 + 16 - 1) * 1024 + (k3 + 16) * 32 + l3 + 16] == -2) {
this.surroundings[(j3 + 16 - 1) * 1024 + (k3 + 16) * 32 + l3 + 16] = i3;
}
if (this.surroundings[(j3 + 16 + 1) * 1024 + (k3 + 16) * 32 + l3 + 16] == -2) {
this.surroundings[(j3 + 16 + 1) * 1024 + (k3 + 16) * 32 + l3 + 16] = i3;
}
if (this.surroundings[(j3 + 16) * 1024 + (k3 + 16 - 1) * 32 + l3 + 16] == -2) {
this.surroundings[(j3 + 16) * 1024 + (k3 + 16 - 1) * 32 + l3 + 16] = i3;
}
if (this.surroundings[(j3 + 16) * 1024 + (k3 + 16 + 1) * 32 + l3 + 16] == -2) {
this.surroundings[(j3 + 16) * 1024 + (k3 + 16 + 1) * 32 + l3 + 16] = i3;
}
if (this.surroundings[(j3 + 16) * 1024 + (k3 + 16) * 32 + (l3 + 16 - 1)] == -2) {
this.surroundings[(j3 + 16) * 1024 + (k3 + 16) * 32 + (l3 + 16 - 1)] = i3;
}
if (this.surroundings[(j3 + 16) * 1024 + (k3 + 16) * 32 + l3 + 16 + 1] == -2) {
this.surroundings[(j3 + 16) * 1024 + (k3 + 16) * 32 + l3 + 16 + 1] = i3;
}
}
}
}
}
}
}
int l2 = this.surroundings[16912];
if (l2 >= 0) {
worldIn.setBlockState(pos, state.withProperty(CHECK_DECAY, Boolean.valueOf(false)), 4);
} else {
this.destroy(worldIn, pos);
}
}
}
}
private void destroy(World worldIn, BlockPos pos) {
this.dropBlockAsItem(worldIn, pos, worldIn.getBlockState(pos), 0);
worldIn.setBlockToAir(pos);
}
@SideOnly(Side.CLIENT)
public void randomDisplayTick(IBlockState stateIn, World worldIn, BlockPos pos, Random rand) {
if (worldIn.isRainingAt(pos.up()) && !worldIn.getBlockState(pos.down()).isTopSolid() && rand.nextInt(15) == 1) {
double d0 = (double)((float)pos.getX() + rand.nextFloat());
double d1 = (double)pos.getY() - 0.05D;
double d2 = (double)((float)pos.getZ() + rand.nextFloat());
worldIn.spawnParticle(EnumParticleTypes.DRIP_WATER, d0, d1, d2, 0.0D, 0.0D, 0.0D);
}
}
public int quantityDropped(Random random) {
return random.nextInt(20) == 0 ? 1 : 0;
}
public Item getItemDropped(IBlockState state, Random rand, int fortune) {
return Item.getItemFromBlock(Blocks.SAPLING);
}
public void dropBlockAsItemWithChance(World worldIn, BlockPos pos, IBlockState state, float chance, int fortune) {
super.dropBlockAsItemWithChance(worldIn, pos, state, chance, fortune);
}
protected void dropApple(World worldIn, BlockPos pos, IBlockState state, int chance) {}
protected int getSaplingDropChance(IBlockState state) {
return 20;
}
public boolean isOpaqueCube(IBlockState state) {
return !this.leavesFancy;
}
@SideOnly(Side.CLIENT)
public void setGraphicsLevel(boolean fancy) {
this.leavesFancy = fancy;
}
@SideOnly(Side.CLIENT)
public BlockRenderLayer getRenderLayer() {
return this.leavesFancy ? BlockRenderLayer.CUTOUT_MIPPED : BlockRenderLayer.SOLID;
}
public boolean causesSuffocation(IBlockState state)
{
return false;
}
public abstract BlockPlanks.EnumType getWoodType(int meta);
@Override
public boolean isShearable(ItemStack item, IBlockAccess world, BlockPos pos){ return true; }
@Override
public boolean isLeaves(IBlockState state, IBlockAccess world, BlockPos pos){ return true; }
@Override
public void beginLeavesDecay(IBlockState state, World world, BlockPos pos) {
if (!(Boolean)state.getValue(CHECK_DECAY)) {
world.setBlockState(pos, state.withProperty(CHECK_DECAY, true), 4);
}
}
@Override
public void getDrops(net.minecraft.util.NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {
Random rand = world instanceof World ? ((World)world).rand : new Random();
int chance = this.getSaplingDropChance(state);
if (fortune > 0) {
chance -= 2 << fortune;
if (chance < 10) chance = 10;
}
if (rand.nextInt(chance) == 0) {
ItemStack drop = new ItemStack(getItemDropped(state, rand, fortune), 1, damageDropped(state));
if (!drop.isEmpty())
drops.add(drop);
}
chance = 200;
if (fortune > 0) {
chance -= 10 << fortune;
if (chance < 40) chance = 40;
}
this.captureDrops(true);
if (world instanceof World)
this.dropApple((World)world, pos, state, chance); // Dammet mojang
drops.addAll(this.captureDrops(false));
}
@SideOnly(Side.CLIENT)
public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
return !this.leavesFancy && blockAccess.getBlockState(pos.offset(side)).getBlock() == this ? false : super.shouldSideBeRendered(blockState, blockAccess, pos, side);
}
}
Последнее редактирование: