Краш при выходе из контейнера

[RareScrap]

Привет, народ. Писал простенький модец на item-сумку, но вылазит какой-то вредных краш, который я не могу пофиксить

package ru.rarescrap.example;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

import static ru.rarescrap.example.TabInventoryExample.MODID;

public class BagItem extends Item {
    public static final Item ITEM = new BagItem().setCreativeTab(CreativeTabs.tabTools);

    public BagItem() {
        setUnlocalizedName("bagItem");
        setTextureName(MODID + ":bag_item");
        setMaxStackSize(1);
    }

    @Override
    public ItemStack onItemRightClick(ItemStack p_77659_1_, World p_77659_2_, EntityPlayer playerEntity) {
        if (!playerEntity.worldObj.isRemote)
            playerEntity.openGui(
                    TabInventoryExample.instance,
                    TabInventoryExample.BAG_GUI_CODE,
                    playerEntity.worldObj,
                    (int) playerEntity.posX,
                    (int) playerEntity.posY,
                    (int) playerEntity.posZ);
        return super.onItemRightClick(p_77659_1_, p_77659_2_, playerEntity);
    }

    @Override
    public boolean onItemUse(ItemStack p_77648_1_, EntityPlayer p_77648_2_, World p_77648_3_, int p_77648_4_, int p_77648_5_, int p_77648_6_, int p_77648_7_, float p_77648_8_, float p_77648_9_, float p_77648_10_) {
        return false;
    }

    @Override
    public boolean onItemUseFirst(ItemStack stack, EntityPlayer player, World world, int x, int y, int z, int side, float hitX, float hitY, float hitZ) {
        return false;
    }


}

package ru.rarescrap.example.gui;

import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import ru.rarescrap.tabinventory.TabHostInventory;
import ru.rarescrap.tabinventory.TabInventory;

public class BagContainer extends Container {
    private EntityPlayer player;
    private ItemStack heldBag;

    public TabHostInventory tabHostInventory;
    public TabInventory tabInventory;

    // TODO: ???
    public BagContainer() {
        tabInventory = new TabInventory("tab_inv", 36, player);
        tabHostInventory = new TabHostInventory("tabs", 4, tabInventory);
        initTabs();
    }

    public BagContainer(EntityPlayer player, ItemStack heldItem) {
        this.player = player;
        this.heldBag = heldItem;

        if (heldItem.getTagCompound() == null) {
            tabInventory = new TabInventory("tab_inv", 36, player);
            tabHostInventory = new TabHostInventory("tabs", 4, tabInventory);
            initTabs();
        } else {
            tabHostInventory.readFromNBT(heldItem.getTagCompound());
            tabInventory.readFromNBT(heldItem.getTagCompound());
        }

        addSlots();
    }

    public void initTabs() {
        if (tabHostInventory.isEmpty()) {
            tabHostInventory.setInventorySlotContents(0, new ItemStack(Items.record_11, 1));
            tabHostInventory.setInventorySlotContents(1, new ItemStack(Items.wooden_pickaxe, 1));
            tabHostInventory.setInventorySlotContents(2, new ItemStack(Items.beef, 1));
            tabHostInventory.setInventorySlotContents(3, new ItemStack(Items.boat, 1));
        }
    }

    private void addSlots() {
        // Расставляем слоты на панели вкладок
        for (int i = 0, slotIndex = 0; i < tabHostInventory.getSizeInventory(); ++i, slotIndex++) {
            this.addSlotToContainer(new Slot(tabHostInventory, i, (i*18 +8) +1, 9) {
                @Override
                public boolean isItemValid(ItemStack p_75214_1_) {
                    return tabHostInventory.isUseableByPlayer(player);
                }
            });

        }

        // Расставляем слоты, которе будут хранить содержимое вкладок
        for (int y = 0; y < 4; ++y) {
            for (int x = 0; x < 9; ++x) {
                this.addSlotToContainer(new Slot(tabInventory, x + y * 9 /*+ 9*/, (x*18 +8) +0, (y * 18) + 25) {
                    @Override
                    public boolean isItemValid(ItemStack p_75214_1_) {
                        return tabInventory.isUseableByPlayer(player);
                    }
                });
            }
        }
    }

    @Override
    public boolean canInteractWith(EntityPlayer p_75145_1_) {
        return true;
    }

    @Override
    public void onContainerClosed(EntityPlayer p_75134_1_) {
        heldBag.setTagCompound(new NBTTagCompound());
        tabHostInventory.writeToNBT(heldBag.getTagCompound());
        tabInventory.writeToNBT(heldBag.getTagCompound());
        super.onContainerClosed(p_75134_1_);
    }
}

package ru.rarescrap.example.gui;

import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.inventory.Container;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import org.lwjgl.opengl.GL11;

import static ru.rarescrap.example.TabInventoryExample.MODID;

public class BagGui extends GuiContainer {
    private static final ResourceLocation background =
            new ResourceLocation(MODID,"textures/gui/bag_gui.png");

    public BagGui(Container p_i1072_1_) {
        super(p_i1072_1_);

        // Высталяем размеры контейнера. Соответствует размерам GUI на текстуре.
        this.xSize = 176;
        this.ySize = 102;
        // Выставляем края контейнера (верхний и левый)
        this.guiLeft = this.width/2 - xSize/2;
        this.guiTop = this.height/2 - ySize/2;
    }

    @Override
    protected void drawGuiContainerBackgroundLayer(float partialTicks, int mouseX, int mouseY) {
        GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);
        this.mc.getTextureManager().bindTexture(background);

        // Отрисовываем текстуру GUI
        drawTexturedModalRect(this.guiLeft, this.guiTop, 0, 0, xSize, ySize);
    }

    @Override
    protected void renderToolTip(ItemStack p_146285_1_, int p_146285_2_, int p_146285_3_) {
        super.renderToolTip(p_146285_1_, p_146285_2_, p_146285_3_);
        ((BagContainer) inventorySlots).tabHostInventory.setTab(p_146285_1_.getUnlocalizedName());
    }
}

Ну и прокси на всякий случай

package ru.rarescrap.example;

import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPostInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.network.IGuiHandler;
import cpw.mods.fml.common.network.NetworkRegistry;
import cpw.mods.fml.common.network.simpleimpl.SimpleNetworkWrapper;
import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.world.World;
import ru.rarescrap.example.gui.BagContainer;
import ru.rarescrap.example.network.TabHandler;
import ru.rarescrap.tabinventory.TabHostInventory;

import static ru.rarescrap.example.TabInventoryExample.instance;
import static ru.rarescrap.example.TabInventoryExample.proxy;

public class CommonProxy implements IGuiHandler {
    public static SimpleNetworkWrapper INSTANCE =
            NetworkRegistry.INSTANCE.newSimpleChannel(TabInventoryExample.MODID.toLowerCase());

    public void preInit(FMLPreInitializationEvent event) {
        GameRegistry.registerItem(BagItem.ITEM, BagItem.ITEM.getUnlocalizedName());

        TabHostInventory.registerHandler(INSTANCE, TabHandler.class, 0);
    }

    public void init(FMLInitializationEvent event) {
        NetworkRegistry.INSTANCE.registerGuiHandler(instance, proxy);
    }

    public void postInit(FMLPostInitializationEvent event) {}

    @Override
    public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        switch (ID) {
            case TabInventoryExample.BAG_GUI_CODE:
                return new BagContainer(player, player.getHeldItem());
        }
        return null;
    }

    @Override
    public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        return null; // Переопределяется в ClientProxy
    }
}

package ru.rarescrap.example;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.world.World;
import ru.rarescrap.example.gui.BagContainer;
import ru.rarescrap.example.gui.BagGui;

public class ClientProxy extends CommonProxy {
    @Override
    public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        switch (ID) {
            case TabInventoryExample.BAG_GUI_CODE:
                return new BagGui(new BagContainer(player, player.getHeldItem()));
        }

        return null;
    }
}

И вот какое дело. ПКМ на итем открывает гуи и все хорошо. Закрываю - тоже все хорошо. Открываю его второй раз - получаю краш. Гугл выдает что метод onBlockActivated должен возвращать true, но никакого блока у меня нет. Поиск на форуме дал это тему, но решения там не нашел. Хелп, плз

 

[RareScrap]

Там тоже самое?

Кидаю на всякий случай. Но по большому счету да, он такой же

---- Minecraft Crash Report ----
// Don't be sad. I'll do better next time, I promise!

Time: 22.09.18 15:45
Description: Ticking memory connection

java.lang.NullPointerException: Ticking memory connection
    at net.minecraft.network.NetHandlerPlayServer.processPlayerBlockPlacement(NetHandlerPlayServer.java:657)
    at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.processPacket(C08PacketPlayerBlockPlacement.java:74)
    at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.processPacket(C08PacketPlayerBlockPlacement.java:122)
    at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)
    at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)
    at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
    at net.minecraft.network.NetHandlerPlayServer.processPlayerBlockPlacement(NetHandlerPlayServer.java:657)
    at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.processPacket(C08PacketPlayerBlockPlacement.java:74)
    at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.processPacket(C08PacketPlayerBlockPlacement.java:122)
    at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)

-- Ticking connection --
Details:
    Connection: net.minecraft.network.NetworkManager@5498b269
Stacktrace:
    at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)
    at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

-- System Details --
Details:
    Minecraft Version: 1.7.10
    Operating System: Windows 10 (amd64) version 10.0
    Java Version: 1.8.0_131, Oracle Corporation
    Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
    Memory: 603807832 bytes (575 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)
    JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
    AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
    IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 94
    FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1558 4 mods loaded, 4 mods active
    States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
    UCHIJAAAA    mcp{9.05} [Minecraft Coder Pack] (minecraft.jar)
    UCHIJAAAA    FML{7.10.99.99} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.4.1558-1.7.10.jar)
    UCHIJAAAA    Forge{10.13.4.1558} [Minecraft Forge] (forgeSrc-1.7.10-10.13.4.1558-1.7.10.jar)
    UCHIJAAAA    tabinventoryexample{1.0} [tabinventoryexample] (MinecraftTabInventory_main)
    GL info: ~~ERROR~~ RuntimeException: No OpenGL context found in the current thread.
    Profiler Position: N/A (disabled)
    Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
    Player Count: 1 / 8; [EntityPlayerMP['TestPlayer'/137, l='New World', x=61,73, y=65,00, z=195,07]]
    Type: Integrated Server (map_client.txt)
    Is Modded: Definitely; Client brand changed to 'fml,forge'

Попробуй поместить его в коммон-прокси

Попробовать-то я попробую, но какой в этом смысл? Зачем клиентский код в коммон толкать?

 

[RareScrap]

Помог туториал от coolalias'а. Краш вызывался из-за того, что Item#getMaxItemUseDuration() возвращал 0. Оказывается он должен возвращать число > 0.

Почему это имеет значение - вообще хз. Если кто разбирается, объясните плз.